Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Search Default state on mobile #2414

Merged
merged 8 commits into from
Apr 9, 2024
Merged

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented Apr 9, 2024

Summary of Changes

Provide a brief description of the changes made in this PR. Explain the problem you are fixing or the feature you are adding.

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After
Screenshot 2024-04-08 at 20 50 13 Screenshot 2024-04-09 at 03 34 53

Edge Cases

light mode
Screenshot 2024-04-08 at 20 41 22

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 6:40pm

@github-actions github-actions bot added the mobile label Apr 9, 2024
Copy link

github-actions bot commented Apr 9, 2024

Bundle Sizes

Compared against 13a3d1c

Route: No significant changes found

Dynamic import: No significant changes found

@Rohan-cp Rohan-cp changed the title base update Search Default state on mobile Apr 9, 2024
@Rohan-cp Rohan-cp requested a review from Robinnnnn April 9, 2024 07:33
@Robinnnnn Robinnnnn merged commit 8f9565e into main Apr 9, 2024
8 of 9 checks passed
@Robinnnnn Robinnnnn deleted the rohan/search-default-mobile branch April 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants