Make the token draggable #2441
Merged
Make the token draggable #2441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…z/gallery-editor-token-draggable
Bundle SizesCompared against 0b6d352 Route: No significant changes found Dynamic import: No significant changes found |
jakzaizzat
changed the title
jakzaizzat
commented
Apr 26, 2024
Comment on lines
-250
to
-255
| transform: [ | ||
| { translateY: translateY.value ?? 0 }, | ||
| { | ||
| scale: withSpring(isGestureActive.value ? 1.05 : 1), | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Remove the scale for the row here. Kind of weird when hovering the token to drag but the **row ** as triggered too
jakzaizzat
commented
Apr 26, 2024
Comment on lines
+81
to
+89
| <SortableTokenGrid | ||
| columns={row.columns} | ||
| items={row.items} | ||
| size={widthPerToken} | ||
| scrollContentOffsetY={scrollContentOffsetY} | ||
| scrollViewRef={scrollViewRef} | ||
| onDragStart={handleDragStart} | ||
| onDragEnd={handleDragEnd} | ||
| /> |
There was a problem hiding this comment.
This component responsible to render the item in grid view
There was a problem hiding this comment.
can we add this as a comment?
Robinnnnn
approved these changes
Apr 26, 2024
Comment on lines
+81
to
+89
| <SortableTokenGrid | ||
| columns={row.columns} | ||
| items={row.items} | ||
| size={widthPerToken} | ||
| scrollContentOffsetY={scrollContentOffsetY} | ||
| scrollViewRef={scrollViewRef} | ||
| onDragStart={handleDragStart} | ||
| onDragEnd={handleDragEnd} | ||
| /> |
There was a problem hiding this comment.
can we add this as a comment?
Comment on lines
53
to
55
| style={{ | ||
| height: containerHeight, | ||
| }} |
There was a problem hiding this comment.
let's memoize this object
…z/gallery-editor-token-draggable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Demo or Before/After Pics
CleanShot.2024-04-26.at.15.02.22.mp4
Edge Cases
Testing Steps
Provide steps on how the reviewer can test the changes.
Checklist
Please make sure to review and check all of the following: