Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display universal auth modal when attempting authenticated actions #2442

Merged
merged 4 commits into from
Apr 25, 2024

Conversation

Robinnnnn
Copy link
Contributor

Summary of Changes

Display the proper, higher-level auth modal when attempting universal actions

Demo or Before/After Pics

Before After
Screenshot 2024-04-25 at 2 17 58 PM Screenshot 2024-04-25 at 2 17 31 PM

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 6:42pm

@github-actions github-actions bot added the web label Apr 25, 2024
Copy link

github-actions bot commented Apr 25, 2024

Bundle Sizes

Compared against 9e5d88e

Route Size (gzipped) Diff
/ 117.8 KB -357.74 KB
/[username] 348.48 KB -357.08 KB
/[username]/[collectionId] 354.72 KB -357.08 KB
/[username]/bookmarks 354.32 KB -357.08 KB
/[username]/followers 353.14 KB -357.08 KB
/[username]/galleries 372.92 KB -357.08 KB
/[username]/galleries/[galleryId] 351.67 KB -357.08 KB
/[username]/posts 443.66 KB -357.14 KB
/_app 1.43 MB +363.79 KB
/auth/twitter 83.98 KB -357.8 KB
/community/[chain]/[contractAddress] 439.68 KB -357.15 KB
/community/artblocks/[contractAddress]/[projectId] 439.71 KB -357.15 KB
/community/prohibition/[contractAddress]/[projectId] 439.71 KB -357.15 KB
/deprecatedshop 441.65 KB -43.41 KB
/explore 342.48 KB -357.72 KB
/following 414.47 KB -357.18 KB
/home 416.09 KB -357.17 KB
/latest 413.98 KB -357.14 KB
/membership/general 408.42 KB -43.12 KB
/membership/gold 278.32 KB -43.12 KB
/membership/silver 278.32 KB -43.12 KB
/mint/mementos 404.09 KB -43.12 KB
/mobile 310.56 KB -357.72 KB
/post/[postId] 402.12 KB -357.11 KB
Dynamic import Size (gzipped) Diff
../src/components/WalletSelector/WalletSelector.tsx -> ./multichain/MultichainWalletSelector 284.25 KB -45.33 KB
../src/components/WalletSelector/WalletSelector.tsx -> ~/contexts/auth/EthereumProviders 186.47 KB -43.09 KB

@Robinnnnn Robinnnnn merged commit 19ff3a6 into main Apr 25, 2024
6 of 7 checks passed
@Robinnnnn Robinnnnn deleted the robin/show-proper-auth-modal branch April 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant