Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix profile skeleton #2454

Merged
merged 1 commit into from
May 2, 2024
Merged

fix profile skeleton #2454

merged 1 commit into from
May 2, 2024

Conversation

pvicensSpacedev
Copy link
Collaborator

@pvicensSpacedev pvicensSpacedev commented May 2, 2024

Summary of Changes

  • Temporary fix: Changed length of the sliced tokens so that the first token's pending state is the one showing the skeleton

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
gallery 🔄 Building (Inspect) Visit Preview May 2, 2024 7:37pm

@github-actions github-actions bot added the web label May 2, 2024
@Robinnnnn Robinnnnn merged commit 7df6903 into main May 2, 2024
6 of 7 checks passed
@Robinnnnn Robinnnnn deleted the pato/fix-profile-skeleton branch May 2, 2024 19:38
Copy link

github-actions bot commented May 2, 2024

Bundle Sizes

Compared against 894233b

Route: No significant changes found

Dynamic import: No significant changes found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants