Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for missing preview cards in search default mobile #2464

Merged
merged 1 commit into from
May 8, 2024

Conversation

Rohan-cp
Copy link
Collaborator

@Rohan-cp Rohan-cp commented May 8, 2024

Demo or Before/After Pics

  • If this is a new feature, include screenshots or recordings of the feature in action.
  • If this PR makes visual changes, include before and after screenshots.
Before After
Screenshot 2024-05-07 at 23 39 50 Screenshot 2024-05-07 at 23 39 50

Edge Cases

List any common edge cases that you have considered and tested.

Testing Steps

Provide steps on how the reviewer can test the changes.

Checklist

Please make sure to review and check all of the following:

  • I've tested the changes and all tests pass.
  • (if web) I've tested the changes on various desktop screen sizes to ensure responsiveness.
  • (if mobile) I've tested the changes on both light and dark modes.

@Rohan-cp Rohan-cp requested a review from Robinnnnn May 8, 2024 03:41
Copy link

vercel bot commented May 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 3:44am

Copy link

github-actions bot commented May 8, 2024

Bundle Sizes

Compared against 2ceae3c

Route: No significant changes found

Dynamic import: No significant changes found

@Robinnnnn Robinnnnn merged commit 5ae8213 into main May 8, 2024
7 checks passed
@Robinnnnn Robinnnnn deleted the rohan/search-default-fix branch May 8, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants