Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use selector with direct descendant, tested old issue #3416

Closed
wants to merge 1 commit into from

Conversation

Arukuen
Copy link
Contributor

@Arukuen Arukuen commented Feb 5, 2025

fixes #3398
fixes #3406

Tested the previous issue on Local with multisite (subdirectories), with non-admin account (editor). No block error so far.

Copy link

github-actions bot commented Feb 5, 2025

🤖 Pull request artifacts

file commit
pr3416-stackable-3416-merge.zip 207f1c5

github-actions bot added a commit that referenced this pull request Feb 5, 2025
Copy link
Contributor

@bfintal bfintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the way column ordering works by changing the main selector will cause unforeseen problems. Since the underlying issue is that the reordering styles are also affecting nested columns, the better solution would be to introduce something that limits the styles from only being applied to the current columns (and not to their children)

@bfintal
Copy link
Contributor

bfintal commented Feb 6, 2025

Closed in favor of #3423

@bfintal bfintal closed this Feb 6, 2025
@bfintal bfintal deleted the fix/3398/3406-column-arrangment branch February 6, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants