Close event channel on event listener removal. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timoreimann
force-pushed
the
close-event-channel-on-events-listener-removal
branch
from
154fa94 to
43f943b
Compare
On invocation of RemoveEventsListener, wait for all pending goroutines to complete and close the events channel afterwards. This will enable clients for-looping through the event channel to terminate naturally. Also merge two tests into one covering all relevant cases.
timoreimann
force-pushed
the
close-event-channel-on-events-listener-removal
branch
from
43f943b to
aabf416
Compare
timoreimann
deleted the
close-event-channel-on-events-listener-removal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On invocation of
RemoveEventsListener, wait for all pending goroutines to complete and close the events channel afterwards. This will enable clients for-looping through the event channel to terminate naturally.Also merge two tests into one covering all relevant cases.
This PR picks up a left out TODO identified along #198.