Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change buildscript to only write version if it should be set #471

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

JohannesDeml
Copy link
Contributor

When versioning: None is set the version values should not be overwritten with "none", but kept as is, since that matches the documentation

Changes

  • Set the buildVersion and and bundleVersionCode only if the value makes sense

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

When versioning: None is set the version values should not be overwritten with "none", but kept as is, since that matches the documentation
Copy link

github-actions bot commented Jul 4, 2024

Cat Gif

@davidmfinol davidmfinol merged commit 2c6e25b into game-ci:main Jul 4, 2024
6 checks passed
@JohannesDeml JohannesDeml deleted the patch-1 branch July 5, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants