Test/eKeiran #7
Test/eKeiran #7
Conversation
There was a problem hiding this comment.
These images are not visible, what I would recommend is, put a one screenshot of the jacoco report as a comment in the PR.
There was a problem hiding this comment.
add unnecessary files in .gitignore, if .gitignore does not exists, make a new file in the root directory and add all unnecessary files into it.
There was a problem hiding this comment.
Please explain this change made in the assembler class, think of it this way: when I request findById() from the repository, Ids are unique so using a single object of Studio seems better than using list as there always going to be one object, it might be the case that I have missed out something so please update me if I missed out on anything
| @@ -128,7 +128,7 @@ public List<StudiosDTO> getAllStudiosByUsers(long id){ | |||
|
|
|||
| public List<StudiosDTO> getAllStudiosByUsersFirstName(String name){ | |||
| List<StudiosDTO> studiosDto = new ArrayList<>(); | |||
| studioRepository.findByUsersSet_FirstName(name).forEach(studio -> studiosDto.add(getStudioMapper().studiosToStudiosDto(studio))); | |||
| studioRepository.findByName(name).forEach(studio -> studiosDto.add(getStudioMapper().studiosToStudiosDto(studio))); | |||
There was a problem hiding this comment.
Please explain this change? Also are you using the latest updates from the studio service repository?
| public StudioRepository studioRepository; | ||
|
|
||
| @Test | ||
| public void testFindByRegistration() { |
There was a problem hiding this comment.
test looks good, just one addition, since it is a list, the recommended way is adding more than one object into the repository and then fetching them into the list and verify the size and properties of those studio object using assertEquals.
htmlCoverageReport/index.html
Outdated
There was a problem hiding this comment.
HTML test coverage should always be excluded from git commit.
Fixes #4
Tests working for the methods assigned to me:
Full coverage of methods in StudioRepository with a report for coverage generated by the JaCoCo plugin.