Test Coverage #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picksitquick
approved these changes
Aug 28, 2023
aprajshekhar
requested changes
Aug 29, 2023
| @@ -100,7 +100,7 @@ public List<StudiosDTO> getAllStudiosByVisibility(boolean visible) { | |||
| public List<StudiosDTO> getAllStudiosByCommunity(int community) { | |||
| List<StudiosDTO> studiosDto = new ArrayList<>(); | |||
| if (community == 1) { | |||
| studioRepository.findByCommunity(community).forEach(studio -> studiosDto.add(getStudioMapper().studiosToStudiosDto(studio))); | |||
| studioRepository.findByIsCommunity(community).forEach(studio -> studiosDto.add(getStudioMapper().studiosToStudiosDto(studio))); | |||
There was a problem hiding this comment.
Observational: Returning the list within the if block can remove the need for else block.
| @@ -0,0 +1,4 @@ | |||
|
|
|||
|
|
||
|
|
||
| @DataJpaTest(properties="spring.cloud.config.enabled=false") | ||
| @TestPropertySource("classpath:test.properties") |
There was a problem hiding this comment.
Let's use application.properties in the test/resources. The idea is to follow similar pattern across the projects.
|
|
||
| @DataJpaTest(properties="spring.cloud.config.enabled=false") | ||
| @TestPropertySource("classpath:test.properties") | ||
| @EntityScan("com.gamedoora.model.*") // Scanning the model(s) |
There was a problem hiding this comment.
Let's move this to the Application class.
| @@ -0,0 +1,15 @@ | |||
| # H2 Database | |||
There was a problem hiding this comment.
Let's add these properties to application properties in test/resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # Test Coverage for Studio Repository #6
Changes
Remaining