Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating system-D to add MS logging #54

Merged
merged 10 commits into from
Mar 2, 2024
Merged

Updating system-D to add MS logging #54

merged 10 commits into from
Mar 2, 2024

Conversation

picksitquick
Copy link
Contributor

Proposed Changes

  • We need to have logging at microservice level so that we can keep track of any issue which we might encounter.
  • We need to make sure the log rotation works in parallel to logging process.
  • This PR can be used as a POC for other MS and we can implement similar logging structure.
  • Please note, we need to test and monitor the changes after merging, so make sure to revert changes if things don't work as expected.

@picksitquick picksitquick added enhancement New feature or request addition Add a new element to the code base. labels Jan 20, 2024
@picksitquick picksitquick self-assigned this Jan 20, 2024
aprajshekhar
aprajshekhar approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@aprajshekhar aprajshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i might move us to pure Spring Boot based one later.

@aprajshekhar aprajshekhar merged commit bd7ddff into main Mar 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aprajshekhar aprajshekhar aprajshekhar approved these changes

Assignees

@picksitquick picksitquick

Labels
addition Add a new element to the code base. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picksitquick @aprajshekhar