Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issues which are causing failure in test cases and DB creation #56

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

picksitquick
Copy link
Contributor

Proposed Changes

  • Currently the DB was down, we changed the Repository ID from Long to String for an entity but forgot to update the same in JPA.
  • This PR should fix the DB fail issue
  • Also, certain method in a repository was calling incorrect property from an entity, an incorrect mapping between repository and entity was made which now should be fixed.
  • RCA: the main reason why the tests were failing was we changed the Id param for an entity class but did not change the repository method which are dependent on those Ids, once the methods were fixed all test cases passed.
  • New Branch was created which does not contain previous commit history.

@picksitquick picksitquick added the bug Something isn't working label Feb 24, 2024
@picksitquick picksitquick self-assigned this Feb 24, 2024
Copy link
Member

@aprajshekhar aprajshekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aprajshekhar aprajshekhar merged commit d239fcc into gamedoora:main Feb 24, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants