Extract profile spherical velocity and data load #386
+648
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdson extrapolation into second order
…tput volume and mass in gamer_extract_profile
…xtract_profile_sph_vel_and_data_load
…tract_profile_sph_vel_and_data_load
hsinhaoHHuang
suggested changes
Jan 8, 2025
There was a problem hiding this comment.
@vivi235711
Thank you for providing this useful tool.
I have finished the PR review.
Please see my comments when you have time and let me know if they are not clear.
Thanks!
tool/analysis/gamer_extract_profile/GAMER_Functions/LoadData.cpp
Outdated
Show resolved
Hide resolved
tool/analysis/gamer_extract_profile/GAMER_Functions/LoadData_HDF5.cpp
Outdated
Show resolved
Hide resolved
tool/analysis/gamer_extract_profile/GAMER_Functions/LoadData_HDF5.cpp
Outdated
Show resolved
Hide resolved
tool/analysis/gamer_extract_profile/GAMER_Functions/LoadData_HDF5.cpp
Outdated
Show resolved
Hide resolved
tool/analysis/gamer_extract_profile/GAMER_Functions/LoadData_HDF5.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
1708
to
1716
| if ( OutputSphere ) | ||
| { | ||
| sprintf( FileName[Var++], "%s", "AveVr" ); | ||
| sprintf( FileName[Var++], "%s", "AveVtheta"); | ||
| sprintf( FileName[Var++], "%s", "AveVphi" ); | ||
| sprintf( FileName[Var++], "%s", "AveWr" ); | ||
| sprintf( FileName[Var++], "%s", "AveWtheta"); | ||
| sprintf( FileName[Var++], "%s", "AveWphi" ); | ||
| } |
There was a problem hiding this comment.
It seems OutputSphere only supports ELBDM currently. Would we plan to also support HYDRO? The coordinate transformation should also work for the hydro velocity.
There was a problem hiding this comment.
Now can support hydro.
May I ask what hydro test problem you use to test this code?
Rename variables, remove useless line, modify some if statements, and add usage
|
@hsinhaoHHuang Thanks for your detailed reviewed! I've updated the code based on your comments. Please take a look when you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance GAMER_ExtractProfile with reading hybrid scheme output, improved accuracy, shell-average velocity, and spherical velocity output.