Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarto vignettes instead of R/Markdown #7

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Conversation

zeileis
Copy link
Member

@zeileis zeileis commented Oct 4, 2024

Niki @freezenik & Mikis @mstasinopoulos, following the discussion in #6 I have moved all .Rmd vignettes to .qmd now. I've adapted the output format and vignette builder accordingly. Also the DESCRIPTION now has quarto instead of knitr in the Suggests and VignetteBuilder. Finally, I excluded all vignettes (except gamlss2.qmd) from building in the package.

@freezenik
Copy link
Member

Merged branches

@freezenik freezenik closed this Oct 8, 2024
@zeileis zeileis reopened this Oct 8, 2024
@zeileis
Copy link
Member Author

zeileis commented Oct 8, 2024

Niki @freezenik, here's what happened:

  • You had just "closed" the PR with the comment "Merged branches". That's why nothing was merged.
  • I have simply re-opened the PR but the GitHub Action failed.
  • So I added eval=FALSE to the last code chunk in spatial.qmd because it (a) had a hanging library (without a package name) and (b) the st_read() call fails. I added #FIXME# comments in the problematic lines.
  • Now the GitHub Action completes successfully again.

The next step for you is to click on the little arrow next to the big green button "Merge pull request" and select "Squash and merge". This will actually merge the branches. Afterwards you can delete the quarto-vignettes branch using the button that appears here.

@freezenik freezenik merged commit e8afc84 into main Oct 8, 2024
1 check passed
@freezenik freezenik deleted the quarto-vignettes branch October 8, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants