don't nest parent in child Sortable

when nesting Sortable's, we're not interested in this error: "HierarchyRequestError: Failed to execute 'appendChild' on 'Node': The new child element contains the parent."
gantry · Aug 21, 2015 · e51dc53 · e51dc53
1 parent a42d0bb
commit e51dc53
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/Sortable.js b/Sortable.js
@@ -603,7 +603,9 @@
 					_cloneHide(isOwner);
 
 					if (_onMove(rootEl, el, dragEl, dragRect, target, targetRect) !== false) {
-						el.appendChild(dragEl);
+						if (!dragEl.contains(el)) {
+							el.appendChild(dragEl);
+						}
 						this._animate(dragRect, dragEl);
 						target && this._animate(targetRect, target);
 					}
@@ -644,10 +646,12 @@
 							after = (nextSibling !== dragEl) && !isLong || halfway && isLong;
 						}
 
-						if (after && !nextSibling) {
-							el.appendChild(dragEl);
-						} else {
-							target.parentNode.insertBefore(dragEl, after ? nextSibling : target);
+						if (!dragEl.contains(el)) {
+							if (after && !nextSibling) {
+								el.appendChild(dragEl);
+							} else {
+								target.parentNode.insertBefore(dragEl, after ? nextSibling : target);
+							}
 						}
 
 						this._animate(dragRect, dragEl);