Merge pull request #84 from gardener/fix-panic-migrate-secret-update

fix panic on failed secret update on hash migration
gardener · Jul 28, 2021 · 8f6d7b6 · 8f6d7b6
2 parents 96d3cea + af3352e
commit 8f6d7b6
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/pkg/controller/issuer/certificate/reconciler.go b/pkg/controller/issuer/certificate/reconciler.go
@@ -937,12 +937,12 @@ func (r *certReconciler) migrateSpecHash(logctx logger.LogContext, obj resources
 		return r.failed(logctx, obj, api.StateError, fmt.Errorf("find all certificates by old hash failed: %w", err))
 	}
 
-	for _, obj := range objs {
-		if _, ok := resources.GetLabel(obj.Data(), LabelCertificateNewHashKey); !ok {
-			obj.SetLabels(resources.AddLabel(obj.GetLabels(), LabelCertificateNewHashKey, specNewHash))
-			err = obj.Update()
+	for _, secret := range objs {
+		if _, ok := resources.GetLabel(secret.Data(), LabelCertificateNewHashKey); !ok {
+			secret.SetLabels(resources.AddLabel(secret.GetLabels(), LabelCertificateNewHashKey, specNewHash))
+			err = secret.Update()
 			if err != nil {
-				return r.failed(logctx, obj, api.StateError, fmt.Errorf("updating label for certificate secret %s failed: %w", obj.ObjectName(), err))
+				logctx.Warnf("updating label for certificate secret %s failed: %w", secret.ObjectName(), err)
 			}
 		}
 	}