Support DNSRecord.spec.class by annotation cert.gardener.cloud/dnsrecord-class
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
kind/enhancement
gardener-prow
bot
added
the
size/S
gardener-robot-ci-1
added
reviewed/ok-to-test
|
LGTM label has been added. Git tree hash: 02fee864eb1429bd0c7a111e16f323ac4e360eb0
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
gardener-robot-ci-3
added
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Allow to specify the extension class for a DNS challenge using
DNSRecordsby setting the annotationcert.gardener.cloud/dnsrecord-class. It is needed for Gardener internal purposes only. If aCertificateis created on the Garden runtime cluster, theTXTrecord for the DNS challenge is created viaDNSRecordsresources. OnlyDNSRecordswith.spec.class=gardenwill be managed by the provider extension running there.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: