Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for switching the dns-controller-manager image #421

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marc1404
Copy link
Member

@marc1404 marc1404 commented Jan 20, 2025

How to categorize this PR?

/area scalability
/kind task

What this PR does / why we need it:

This PR adds support for switching the image to be used for the dns-controller-manager deployment.
It adds a secondary entry in the imagevector.yaml that allows referencing a different version of the dns-controller-manager image.

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

/cc @MartinWeindel

Release note:

Add support for switching the `dns-controller-manager` image.

@gardener-robot gardener-robot added kind/api-change API change with impact on API users needs/second-opinion Needs second review by someone else area/scalability Scalability related kind/task General task needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 20, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 20, 2025
@marc1404 marc1404 force-pushed the feat/add-support-for-dns-controller-manager-image-switch branch from 3546561 to a2db407 Compare January 20, 2025 14:36
@gardener-robot gardener-robot added size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) and removed size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jan 20, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/scalability Scalability related kind/api-change API change with impact on API users kind/task General task needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants