Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing entries in /etc/hosts of remote local setup #11187

Conversation

marc1404
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

When using the remote local setup and trying to run E2E tests you receive the following error:

make test-e2e-local
./hack/test-e2e-local.sh --procs=5 --label-filter="default" ./test/e2e/gardener/...
> E2E Tests
Hostnames for the following Shoots are missing in /etc/hosts:
 - 172.18.255.1 api.e2e-wake-up-ncp.local.internal.local.gardener.cloud
 - 172.18.255.1 api.e2e-wake-up-ncp.local.external.local.gardener.cloud
 - 172.18.255.1 gu-local--e2e-rotate.ingress.local.seed.local.gardener.cloud
 - 172.18.255.1 gu-local--e2e-rotate-wl.ingress.local.seed.local.gardener.cloud
To access shoot clusters and run e2e tests, you have to extend your /etc/hosts file.
Please refer to https://github.com/gardener/gardener/blob/master/docs/deployment/getting_started_locally.md#accessing-the-shoot-cluster

make: *** [Makefile:431: test-e2e-local] Error 1

This PR adds the missing entries to the remote local setup's /etc/hosts.

Which issue(s) this PR fixes:

n.a.

Special notes for your reviewer:

/cc @istvanballok

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from istvanballok January 16, 2025 16:55
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙂
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2025
Copy link
Contributor

gardener-prow bot commented Jan 16, 2025

LGTM label has been added.

Git tree hash: 5e9a971188a552775c5b970d3cae2c943c72929e

Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required
/approve

Copy link
Contributor

gardener-prow bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2025
@gardener-prow gardener-prow bot merged commit 6f286b6 into gardener:master Jan 17, 2025
18 checks passed
@marc1404 marc1404 deleted the fix/remote-local-setup-add-missing-entries-in-etc-hosts branch January 17, 2025 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants