Fix all rubocop errors

.github/workflows/ruby.yml

@@ -25,3 +25,5 @@ jobs:
       run: bundle exec rails db:create db:schema:load --trace
     - name: Run tests
       run: bundle exec rails test
+    - name: Lint
+      run: bundle exec rubocop

Gemfile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 source "https://rubygems.org"
 
 gemspec

Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 begin
   require "bundler/setup"
 rescue LoadError

app/controllers/fogged/resources_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # The Resource API. This API has only 3 methods: create, confirm and destroy.
 #
 # To create a new resource, call the create method with a filename and a

app/jobs/fogged/resources/awsthumbnailjob.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   module Resources
     class AWSThumbnailJob < ActiveJob::Base

app/models/fogged/application_record.rb

@@ -0,0 +1,6 @@
+# frozen_string_literal: true
+module Fogged
+  class ApplicationRecord < ActiveRecord::Base
+    self.abstract_class = true
+  end
+end

app/models/fogged/resource.rb

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
 module Fogged
-  class Resource < ActiveRecord::Base
+  class Resource < ApplicationRecord
     validates :extension, :content_type, :name, presence: true
 
     before_save :ensure_token
@@ -75,7 +76,7 @@ def image?
     def encoding?
       unless encoding_progress.present? &&
              (video? || (image? && Fogged.active_job_enabled))
-        return
+        return false
       end
 
       encoding_progress < 100

app/models/fogged/resources/awsencoder.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   module Resources
     class AWSEncoder

app/models/fogged/resources/encoder.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   module Resources
     class Encoder

app/serializers/fogged/resource_serializer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   class ResourceSerializer < ActiveModel::Serializer
     type :resource

config/routes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Fogged::Engine.routes.draw do
   resources :resources do
     put :confirm, on: :member

db/migrate/20141103143408_create_fogged_resources.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateFoggedResources < ActiveRecord::Migration
   def change
     create_table :fogged_resources do |t|
@@ -6,7 +7,7 @@ def change
       t.integer :width
       t.integer :height
       t.string :extension, null: false
-      t.boolean :uploading
+      t.boolean :uploading # rubocop:disable Rails/ThreeStateBooleanColumn
       t.string :content_type, null: false
       t.integer :encoding_progress
       t.string :encoding_job_id

lib/fogged.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Gem.loaded_specs["fogged"].dependencies.select { |d| d.type == :runtime }.each do |d|
   require d.name
 end
@@ -83,7 +84,7 @@ def self.aws_resources
       aws_access_key_id: Fogged.aws_key,
       aws_secret_access_key: Fogged.aws_secret
     }
-    storage_options.merge!(region: Fogged.aws_region) if Fogged.aws_region
+    storage_options[:region] = Fogged.aws_region if Fogged.aws_region
     Fogged.storage = Fog::Storage.new(storage_options)
 
     Fogged.storage.directories.get(Fogged.aws_bucket)

lib/fogged/engine.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   class Engine < ::Rails::Engine
     isolate_namespace Fogged

lib/fogged/has_many_resources.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   module HasManyResources
     extend ActiveSupport::Concern
@@ -20,7 +21,7 @@ def has_many_resources(*args)
     private
 
     def _check_resources
-      return if resources.to_a.select(&:uploading).empty?
+      return if resources.to_a.none?(&:uploading)
 
       errors.add(:resources, I18n.t("fogged.resources.still_uploading"))
     end

lib/fogged/has_one_resource.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   module HasOneResource
     extend ActiveSupport::Concern

lib/fogged/inflections.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 ActiveSupport::Inflector.inflections(:en) do |inflect|
   inflect.acronym "AWSEncoder"
   inflect.acronym "AWSThumbnailJob"

lib/fogged/utils.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   def self.directory_public_url(directory_name)
     case Fogged.provider

lib/fogged/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   VERSION = "0.2.2"
 end

lib/fogged/with_directory.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   def self.with_directory(directory_name)
     old_resources = Fogged._resources

lib/fogged/zencoder_additional_outputs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module Fogged
   mattr_accessor :zencoder_additional_outputs_block
 

lib/tasks/fogged_tasks.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # desc "Explaining what the task does"
 # task :fogged do
 #   # Task goes here

test/controllers/concerns/json_test_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module JsonTestHelper
   extend ActiveSupport::Concern
 

test/controllers/concerns/resource_test_helper.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module ResourceTestHelper
   extend ActiveSupport::Concern
   include JsonTestHelper

test/controllers/fogged/resources_controller/confirm_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/controllers/fogged/resources_controller/create_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/controllers/fogged/resources_controller/destroy_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/controllers/fogged/resources_controller/show_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/controllers/fogged/resources_controller/update_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/controllers/fogged/resources_controller/zencoder_notification_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/dummy/Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 

test/dummy/app/controllers/application_controller.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ApplicationController < ActionController::Base
   # Prevent CSRF attacks by raising an exception.
   # For APIs, you may want to use :null_session instead.

test/dummy/app/controllers/images_controllers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class ImagesControllers < ApplicationController
   def index
     render json: Image.all

test/dummy/app/helpers/application_helper.rb

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 module ApplicationHelper
 end

test/dummy/app/models/application_record.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+class ApplicationRecord < ActiveRecord::Base
+  primary_abstract_class
+end

test/dummy/app/models/image.rb

@@ -1,3 +1,4 @@
-class Image < ActiveRecord::Base
+# frozen_string_literal: true
+class Image < ApplicationRecord
   has_one_resource
 end

test/dummy/app/models/movie.rb

@@ -1,4 +1,5 @@
-class Movie < ActiveRecord::Base
+# frozen_string_literal: true
+class Movie < ApplicationRecord
   has_many :movie_fogged_resources
   has_many_resources through: :movie_fogged_resources
 end

test/dummy/app/models/movie_fogged_resource.rb

@@ -1,4 +1,5 @@
-class MovieFoggedResource < ActiveRecord::Base
+# frozen_string_literal: true
+class MovieFoggedResource < ApplicationRecord
   belongs_to :movie
   belongs_to :resource, class_name: "Fogged::Resource"
 end

test/dummy/bin/bundle

@@ -1,3 +1,4 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
 load Gem.bin_path("bundler", "bundle")

test/dummy/bin/delayed_job

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require File.expand_path(File.join(File.dirname(__FILE__), "..", "config", "environment"))
 require "delayed/command"

test/dummy/bin/rails

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 APP_PATH = File.expand_path("../config/application", __dir__)
 require_relative "../config/boot"
 require "rails/commands"

test/dummy/bin/rake

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 require_relative "../config/boot"
 require "rake"
 Rake.application.run

test/dummy/config.ru

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # This file is used by Rack-based servers to start the application.
 
 require File.expand_path("config/environment", __dir__)

test/dummy/config/application.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require File.expand_path("boot", __dir__)
 
 require "rails/all"

test/dummy/config/boot.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Set up gems listed in the Gemfile.
 ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../../Gemfile", __dir__)
 

test/dummy/config/environment.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Load the Rails application.
 require File.expand_path("application", __dir__)
 

test/dummy/config/environments/development.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

test/dummy/config/environments/production.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

test/dummy/config/environments/test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Rails.application.configure do
   config.active_support.test_order = :sorted
   # Settings specified here will take precedence over those in config/application.rb.

test/dummy/config/initializers/assets.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Version of your assets, change this if you want to expire all your assets.

test/dummy/config/initializers/backtrace_silencers.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.

test/dummy/config/initializers/cookies_serializer.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.action_dispatch.cookies_serializer = :json

test/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.

test/dummy/config/initializers/fog.rb

@@ -1 +1,2 @@
+# frozen_string_literal: true
 Fog.mock! if Rails.env.test?

test/dummy/config/initializers/fogged.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Fogged.configure do |config|
   config.provider = :aws
   config.aws_key = ENV.fetch("AWS_KEY", nil)

test/dummy/config/initializers/inflections.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

test/dummy/config/initializers/mime_types.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # Add new mime types for use in respond_to blocks:

test/dummy/config/initializers/session_store.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 Rails.application.config.session_store :cookie_store, key: "_dummy_session"

test/dummy/config/initializers/wrap_parameters.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # Be sure to restart your server when you modify this file.
 
 # This file contains settings for ActionController::ParamsWrapper which

test/dummy/config/routes.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Rails.application.routes.draw do
   resources :images, only: :index
   mount Fogged::Engine => "/"

test/dummy/db/migrate/20141104135257_create_images.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateImages < ActiveRecord::Migration
   def change
     create_table :images, force: true do |t|

test/dummy/db/migrate/20141104152227_create_movies.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateMovies < ActiveRecord::Migration
   def change
     create_table :movies, force: true do |t|

test/dummy/db/migrate/20141104152345_create_movie_fogged_resources.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateMovieFoggedResources < ActiveRecord::Migration
   def change
     create_table :movie_fogged_resources, force: true do |t|

test/dummy/db/migrate/20141105073909_create_delayed_jobs.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 class CreateDelayedJobs < ActiveRecord::Migration
   def self.up
     create_table :delayed_jobs, force: true do |table|

test/dummy/test/controllers/resources_controller/index_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class ResourcesControllerIndexTest < ActionController::TestCase

test/dummy/test/models/image_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class ImageTest < ActiveSupport::TestCase

test/dummy/test/models/movie_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class MovieTest < ActiveSupport::TestCase

test/fogged_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 class FoggedTest < ActiveSupport::TestCase

test/jobs/fogged/resources/aws_thumbnail_job_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged

test/models/fogged/resource_test.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require "test_helper"
 
 module Fogged