Fix corepack error and update Yarn to 3.7.0 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilgaly
force-pushed
the
fix-corepack-error
branch
from
8a85a9a to
8c5590a
Compare
Motivation: - packageManager setting isn't used of corepack isn't enabled - recent versions of yarn 1 will output an error if packageManager is set but corepack isn't enabled (before 'yarn set version' command is effective) Modifications: Enable corepack in CI workflows. Result: Avoid error in CI workflows.
guilgaly
force-pushed
the
fix-corepack-error
branch
from
8c5590a to
aae0d93
Compare
guilgaly
commented
Dec 4, 2023
| @@ -3977,11 +3977,11 @@ __metadata: | |||
|
|
|||
| "typescript@patch:[email protected]#~builtin<compat/typescript>": | |||
| version: 5.2.2 | |||
| resolution: "typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=d73830" | |||
| resolution: "typescript@patch:typescript@npm%3A5.2.2#~builtin<compat/typescript>::version=5.2.2&hash=f3b441" | |||
There was a problem hiding this comment.
I have no idea why this changed when updating from yarn 3.3.0 to 3.7.0 🤷
There was a problem hiding this comment.
When you updated yarn, I guess you had to do a yarn install.
So, the real dependencies were updated (weird one, I admit)
Isammoc
approved these changes
Dec 4, 2023
notdryft
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.