Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Logback configuration should be easier to override #32

Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix: Logback configuration should be easier to override #32

merged 1 commit into from
Jul 25, 2024

Conversation

guilgaly
Copy link
Member

In the JVM adapter:

  • Rename default Logback configuration from 'logback-test.xml' to 'logback.xml' (lower priority, easier to override with a user-provided 'logback-test.xml' file).
  • Remove empty and unnecessary 'gatling.conf' file.
  • Remove 'bundle.js' file which somehow remained from some tests early in the project's history...

@guilgaly
fix: Logback configuration should be easier to override
98aa3be 
In the JVM adapter:
- Rename default Logback configuration from 'logback-test.xml' to 'logback.xml' (lower priority, easier to override with a user-provided
'logback-test.xml' file).
- Remove empty and unnecessary 'gatling.conf' file.
- Remove 'bundle.js' file which somehow remained from some tests early in the project's history...
@guilgaly guilgaly requested a review from notdryft July 25, 2024 08:54
@guilgaly guilgaly self-assigned this Jul 25, 2024
@guilgaly guilgaly mentioned this pull request Jul 25, 2024
Merged
@guilgaly guilgaly merged commit a7423d6 into main Jul 25, 2024
1 check passed
@guilgaly guilgaly deleted the default-config-files branch July 25, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slandelle slandelle slandelle approved these changes

@notdryft notdryft notdryft approved these changes

Assignees

@guilgaly guilgaly

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilgaly @slandelle @notdryft