Fix hotkeys matching #142
Merged
Fix hotkeys matching #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
friendlymatthew
approved these changes
Oct 26, 2024
|
@all-contributors please add @TheBestTvarynka for code |
|
I've put up a pull request to add @TheBestTvarynka! 🎉 |
|
Thank you 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for such a great library! I'm using it in my project and am happy with the functionality. It has everything I need.
Unfortunately, I've faced a bug in the hotkeys matching algorithm: it doesn't check that the controls aren't pressed when they're not needed. Let me give you an example to explain the situation better.
Suppose I want to do some action on the
ctrl+mhotkey. The action will be executed even onctrl+shift+morctrl+alt+m. It doesn't seem correct, because I may want to set another action on thectrl+shift+mhotkey. The most common case is when the user wants to add hotkeys for scrolling:ctrl+tabis next andctrl+shift+tabis prev.In this PR, I've fixed this bug by checking if the modifier key is not pressed when it doesn't need to be pressed.