Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSR #67

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix SSR #67

merged 2 commits into from
Mar 12, 2024

Conversation

mondeja
Copy link
Collaborator

@mondeja mondeja commented Mar 12, 2024

No description provided.

@mondeja mondeja added the chore Internal things like configuring checks or minor updates label Mar 12, 2024
@mondeja mondeja requested a review from friendlymatthew March 12, 2024 19:52
@mondeja mondeja changed the title Fix SSR support Fix SSR Mar 12, 2024
@mondeja mondeja removed the request for review from friendlymatthew March 12, 2024 19:58
Comment on lines +49 to +50
#[cfg(not(feature = "ssr"))]
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need cfg_if if you wrap a block like this.

Copy link
Member

@friendlymatthew friendlymatthew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but one quick question:

why do we add the feature = "ssr" for the parameters of use_hotkeys_scoped and others?

@mondeja mondeja merged commit 816a6f0 into gaucho-labs:main Mar 12, 2024
3 checks passed
@mondeja mondeja deleted the fix-lint branch March 12, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal things like configuring checks or minor updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants