Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of a 'DiagnosticPipeline' to characterize the behavior of
tach check
andtach check-external
. These Pipelines can be constructed by implementing a 'FileProcessor' to extract relevant information from incoming files, and a 'FileChecker' to produce Diagnostics from the processed information. These changes serve several purposes:check
andcheck-external
(e.g. ignore directives, eventually modules)tach check-external
as an error instead of a warning #524 Enable to explicitly disallow import of certain external dependencies #535 FR: add support for dependency-groups #565 (generally, enhancements tocheck-external
will be able to easily interact with the Tach module system)