Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize checks #586

Merged
merged 10 commits into from
Feb 5, 2025
Merged

Generalize checks #586

merged 10 commits into from
Feb 5, 2025

Conversation

emdoyle
Copy link
Member

@emdoyle emdoyle commented Feb 1, 2025

This PR introduces the concept of a 'DiagnosticPipeline' to characterize the behavior of tach check and tach check-external. These Pipelines can be constructed by implementing a 'FileProcessor' to extract relevant information from incoming files, and a 'FileChecker' to produce Diagnostics from the processed information. These changes serve several purposes:

@emdoyle emdoyle marked this pull request as ready for review February 3, 2025 23:32
@emdoyle emdoyle mentioned this pull request Feb 4, 2025
@emdoyle emdoyle merged commit 053832a into main Feb 5, 2025
8 of 11 checks passed
@emdoyle emdoyle deleted the generalize-checks branch February 5, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant