-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sanity check on version in CMakeLists.txt file #1224
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
535df30
Add sanity check on version in CMakeLists.txt file
azeey 53ea139
Don't run cmake sanity checks in certain cases
azeey 0a7b430
Reviewer feedback
azeey b52561a
Add support for VERSION_SUFFIX and improve robustness of regex matching
azeey c337964
Merge branch 'master' into azeey/add_cmake_version_sanity_check
azeey dae3090
Merge branch 'master' into azeey/add_cmake_version_sanity_check
azeey c783ff8
Update release.py
j-rivero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
args.source_repo_uri
is designed to provide exact repository URI instead of retrieving it from the local github checkout. Nothing to do with the CMakeListst.txt bussiness I think.You probably want to use here
args.source_tarball_uri
that represents an existing source stored out of the system. In that case the check for a localCMakeLists.txt
file has less sense unless we download and unzip the tarball.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this in c783ff8