Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with garbled text in generated documentation #388

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 14, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#186

Summary

The version of doxygen in Jammy has a bug that generates garbled characters when processing xml comment code blocks in markdown. In this PR, we build doxygen 1.9.2 from source here since the problem appears to be fixed in that version.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This also removes Garden libraries from the list since their
documentation would be generated in the Garden Dockerfile.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Copy link
Contributor

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying these lines into my local Dockerfile and building with 1.9.2 doesn't generate garbled texts anymore.

@azeey azeey merged commit 02deb22 into gazebosim:master Sep 14, 2023
2 checks passed
@azeey azeey deleted the jammy_doxygen_from_source branch September 14, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-sensors: Thermal Camera in Gazebo
2 participants