Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "No space left on device" issue on Github Actions #390

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 20, 2023

🦟 Bug fix

Summary

Our documentation deployment Action is failing with a "No space left on device" error. I think this is because we're creating docker images for each release, but not removing them even though they're not needed anymore.

This PR also removes EOL releases from the deployment script in 3d884be.

This would be easier to review by commit.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@mabelzhang
Copy link
Contributor

mabelzhang commented Sep 20, 2023

Doesn't this just remove the image right away after it's built? Or is a container being spun up elsewhere, so that the latest image won't be pruned?

@azeey
Copy link
Contributor Author

azeey commented Sep 20, 2023

Doesn't this just remove the image right away after it's built? Or is a container being spun up elsewhere, so that the latest image won't be pruned?

The documentation is generated and uploaded during the Dockerfile build process. It calls RUN scripts/build_gz.sh which calls upload_doc.sh (https://github.com/azeey/docs/blob/5a22e956259c9d93cdbe52d17ffd31c5e294bc71/tools/scripts/build_gz.sh#L33). So there's no need to keep the images around.

@azeey azeey merged commit 133db61 into gazebosim:master Sep 20, 2023
2 checks passed
@azeey azeey deleted the fix_low_space branch September 20, 2023 20:00
@azeey azeey mentioned this pull request Oct 2, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants