Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile error with ffmpeg-5.0. #580

Closed
wants to merge 1 commit into from
Closed

Fixed compile error with ffmpeg-5.0. #580

wants to merge 1 commit into from

Conversation

bchoineubility
Copy link
Contributor

🦟 Bug fix

Fixes #579

Summary

When I try to build with ffmpeg-5.0, it occurred compile error by comparing patch [PATCH] Fix compatibility with FFmpeg 5.0 (#325)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@bchoineubility bchoineubility requested a review from marcoag as a code owner March 8, 2024 01:30
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Mar 8, 2024
@mjcarroll
Copy link
Contributor

Since this was originally released to support Ubuntu 18.04 Bionic, I think that we need to continue to maintain support for older versions of libav, in this case you should be able to do it like

#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59, 24, 100)
        int numChannels = this->dataPtr->codecCtx->ch_layout.nb_channels;
#else
        int numChannels = this->dataPtr->codecCtx->channels;
#endif

@bchoineubility
Copy link
Contributor Author

Since this was originally released to support Ubuntu 18.04 Bionic, I think that we need to continue to maintain support for older versions of libav, in this case you should be able to do it like

#if LIBAVCODEC_VERSION_INT >= AV_VERSION_INT(59, 24, 100)
        int numChannels = this->dataPtr->codecCtx->ch_layout.nb_channels;
#else
        int numChannels = this->dataPtr->codecCtx->channels;
#endif

@mjcarroll I close this PR and apply your suggestion and open PR again. thanks.

@bchoineubility bchoineubility deleted the ign-common3 branch March 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants