Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Fix assimp submesh naming #659

Draft
wants to merge 2 commits into
base: gz-common6
Choose a base branch
from

Conversation

luca-della-vedova
Copy link
Member

🦟 Bug fix

Summary

Submeshes were named by the name of the node that contained them, not the actual submesh.
Changed them to be named by submesh name

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Luca Della Vedova <[email protected]>
Signed-off-by: Luca Della Vedova <[email protected]>
@azeey
Copy link
Contributor

azeey commented Jan 7, 2025

Looks like there are some test failures.

@luca-della-vedova
Copy link
Member Author

Yea sorry I was trying to figure out the intent behind this naming decision and whether this change would break any underlying assumption in the loader but haven't got around to it yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants