Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip: use non-deprecated methods #360

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes compiler warnings on macOS.

Summary

This package is using some deprecated methods from libzip, which generates compiler warnings as of 1.10.0 (see release notes).

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fixes compiler warnings on macOS.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from nkoenig as a code owner July 14, 2023 23:24
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #360 (4d58021) into ign-fuel-tools4 (fb27cac) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4d58021 differs from pull request most recent head d0bdff1. Consider uploading reports for the commit d0bdff1 to get more accurate results

@@               Coverage Diff                @@
##           ign-fuel-tools4     #360   +/-   ##
================================================
  Coverage            77.72%   77.72%           
================================================
  Files                   19       19           
  Lines                 2766     2766           
================================================
  Hits                  2150     2150           
  Misses                 616      616           
Impacted Files Coverage Δ
src/Zip.cc 69.87% <100.00%> (ø)

@scpeters scpeters merged commit ed4cea1 into ign-fuel-tools4 Jul 17, 2023
9 checks passed
@scpeters scpeters deleted the scpeters/fix_zip_deprecations branch July 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants