Merge ign-fuel-tools7 ➡️ gz-fuel-tools8 #362
Merged
+442
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support downloading from a referal link Signed-off-by: Nate Koenig <[email protected]> * spelling Signed-off-by: Nate Koenig <[email protected]> * Address comments Signed-off-by: Nate Koenig <[email protected]> --------- Signed-off-by: Nate Koenig <[email protected]>
* 4.8.3 release Signed-off-by: Nate Koenig <[email protected]> * 4.8.3 Signed-off-by: Nate Koenig <[email protected]> --------- Signed-off-by: Nate Koenig <[email protected]>
The ModelIter iterator was fetching all available pages before making the first model available. This PR makes it so that each page is fetched from Fuel when the iterator is advanced. This also adds a new member function FuelClient::Models(onst ModelIdentifier &_id, bool _checkCache) that allows bypassing the cache when getting a list of models owned by a user from the server. --------- Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-fuel-tools4 ➡️ ign-fuel-tools7
Signed-off-by: Addisu Z. Taddese <[email protected]>
Fixes compiler warnings on macOS. Signed-off-by: Steve Peters <[email protected]>
Merge ign-fuel-tools4 ➡️ ign-fuel-tools7
scpeters
commented
Jul 19, 2023
src/FuelClient_TEST.cc
Outdated
| TEST_F(FuelClientTest, ModelsCheckCached) | ||
| { | ||
| ClientConfig config; | ||
| std::string cacheDir = common::joinPaths(PROJECT_BINARY_PATH, "test_cache"); |
There was a problem hiding this comment.
this needs to be fixed since PROJECT_BINARY_PATH is no longer in use
There was a problem hiding this comment.
I think we can use common::cwd as other tests have done.
There was a problem hiding this comment.
good call, I just amended to cfa86f7
azeey
approved these changes
Jul 19, 2023
src/FuelClient_TEST.cc
Outdated
| TEST_F(FuelClientTest, ModelsCheckCached) | ||
| { | ||
| ClientConfig config; | ||
| std::string cacheDir = common::joinPaths(PROJECT_BINARY_PATH, "test_cache"); |
There was a problem hiding this comment.
I think we can use common::cwd as other tests have done.
scpeters
force-pushed
the
scpeters/merge_7_8
branch
from
b683890
to
cfa86f7
Compare
Codecov Report
@@ Coverage Diff @@
## gz-fuel-tools8 #362 +/- ##
==================================================
+ Coverage 75.30% 75.32% +0.02%
==================================================
Files 20 20
Lines 2911 2910 -1
==================================================
Hits 2192 2192
+ Misses 719 718 -1
|
|
the windows test failures are already present on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-fuel-tools7➡️gz-fuel-tools8Branch comparison: gz-fuel-tools8...ign-fuel-tools7
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)