Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing URI header files #435

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes clang-tidy warnings related to types used without their header files.

Summary

Add missing includes for gz::common::URI and gz::fuel_tools::uriToPath

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Resolve clang-tidy warnings.

Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from nkoenig as a code owner August 20, 2024 23:09
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 20, 2024
Copy link
Contributor

@shameekganguly shameekganguly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scpeters scpeters merged commit 9546d4e into gz-fuel-tools9 Aug 20, 2024
10 checks passed
@scpeters scpeters deleted the scpeters/fix_includes branch August 20, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants