Use =default and remove duplicate constructor calls

Signed-off-by: Michael Carroll <[email protected]>

src/Dialog.cc

@@ -50,9 +50,7 @@ Dialog::Dialog()
 }
 
 /////////////////////////////////////////////////
-Dialog::~Dialog()
-{
-}
+Dialog::~Dialog() = default;
 
 /////////////////////////////////////////////////
 QQuickWindow *Dialog::QuickWindow() const

src/MainWindow.cc

@@ -115,9 +115,7 @@ MainWindow::MainWindow()
 }
 
 /////////////////////////////////////////////////
-MainWindow::~MainWindow()
-{
-}
+MainWindow::~MainWindow() = default;
 
 /////////////////////////////////////////////////
 QStringList MainWindow::PluginListModel() const

src/PlottingInterface.cc

@@ -97,9 +97,7 @@ PlotData::PlotData() :
 }
 
 //////////////////////////////////////////////////////
-PlotData::~PlotData()
-{
-}
+PlotData::~PlotData() = default;
 
 //////////////////////////////////////////////////////
 void PlotData::SetValue(const double _value)
@@ -496,9 +494,7 @@ PlottingInterface::PlottingInterface() : QObject(),
 }
 
 //////////////////////////////////////////////////////
-PlottingInterface::~PlottingInterface()
-{
-}
+PlottingInterface::~PlottingInterface() = default;
 
 //////////////////////////////////////////////////////
 void PlottingInterface::unsubscribe(int _chart,

src/plugins/camera_fps/CameraFps.cc

@@ -82,14 +82,12 @@ void CameraFps::OnRender()
 
 /////////////////////////////////////////////////
 CameraFps::CameraFps()
-  : Plugin(), dataPtr(new CameraFpsPrivate)
+  : dataPtr(new CameraFpsPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-CameraFps::~CameraFps()
-{
-}
+CameraFps::~CameraFps() = default;
 
 /////////////////////////////////////////////////
 void CameraFps::LoadConfig(const tinyxml2::XMLElement *)

src/plugins/camera_tracking/CameraTracking.cc

@@ -427,7 +427,7 @@ void CameraTrackingPrivate::OnRender()
 
 /////////////////////////////////////////////////
 CameraTracking::CameraTracking()
-  : Plugin(), dataPtr(new CameraTrackingPrivate)
+  : dataPtr(new CameraTrackingPrivate)
 {
   this->dataPtr->timer = new QTimer(this);
   this->connect(this->dataPtr->timer, &QTimer::timeout, [=]()
@@ -446,9 +446,7 @@ CameraTracking::CameraTracking()
 }
 
 /////////////////////////////////////////////////
-CameraTracking::~CameraTracking()
-{
-}
+CameraTracking::~CameraTracking() = default;
 
 /////////////////////////////////////////////////
 void CameraTracking::LoadConfig(const tinyxml2::XMLElement *)

src/plugins/grid_config/GridConfig.cc

@@ -84,7 +84,7 @@ namespace gz::gui
 
 /////////////////////////////////////////////////
 GridConfig::GridConfig()
-  : gz::gui::Plugin(), dataPtr(std::make_unique<GridConfigPrivate>())
+  : dataPtr(std::make_unique<GridConfigPrivate>())
 {
 }
 

src/plugins/image_display/ImageDisplay.cc

@@ -55,7 +55,7 @@ class ImageDisplayPrivate
 
 /////////////////////////////////////////////////
 ImageDisplay::ImageDisplay()
-  : Plugin(), dataPtr(new ImageDisplayPrivate)
+  : dataPtr(new ImageDisplayPrivate)
 {
 }
 

src/plugins/interactive_view_control/InteractiveViewControl.cc

@@ -387,7 +387,7 @@ bool InteractiveViewControlPrivate::OnViewControlSensitivity(
 
 /////////////////////////////////////////////////
 InteractiveViewControl::InteractiveViewControl()
-  : Plugin(), dataPtr(std::make_unique<InteractiveViewControlPrivate>())
+  : dataPtr(std::make_unique<InteractiveViewControlPrivate>())
 {
 }
 

src/plugins/key_publisher/KeyPublisher.cc

@@ -49,17 +49,15 @@ class KeyPublisherPrivate
 };
 
 /////////////////////////////////////////////////
-KeyPublisher::KeyPublisher(): Plugin(), dataPtr(new KeyPublisherPrivate)
+KeyPublisher::KeyPublisher(): dataPtr(new KeyPublisherPrivate)
 {
   // Advertise publisher node
   this->dataPtr->pub = this->dataPtr->node.Advertise<msgs::Int32>
     (this->dataPtr->topic);
 }
 
 /////////////////////////////////////////////////
-KeyPublisher::~KeyPublisher()
-{
-}
+KeyPublisher::~KeyPublisher() = default;
 
 /////////////////////////////////////////////////
 void KeyPublisher::LoadConfig(const tinyxml2::XMLElement *)

src/plugins/marker_manager/MarkerManager.cc

@@ -659,14 +659,12 @@ void MarkerManagerPrivate::OnWorldStatsMsg(
 
 /////////////////////////////////////////////////
 MarkerManager::MarkerManager()
-  : Plugin(), dataPtr(new MarkerManagerPrivate)
+  : dataPtr(new MarkerManagerPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-MarkerManager::~MarkerManager()
-{
-}
+MarkerManager::~MarkerManager() = default;
 
 /////////////////////////////////////////////////
 void MarkerManager::LoadConfig(const tinyxml2::XMLElement * _pluginElem)

src/plugins/navsat_map/NavSatMap.cc

@@ -48,14 +48,12 @@ class NavSatMapPrivate
 
 /////////////////////////////////////////////////
 NavSatMap::NavSatMap()
-  : Plugin(), dataPtr(new NavSatMapPrivate)
+  : dataPtr(new NavSatMapPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-NavSatMap::~NavSatMap()
-{
-}
+NavSatMap::~NavSatMap() = default;
 
 /////////////////////////////////////////////////
 void NavSatMap::LoadConfig(const tinyxml2::XMLElement *_pluginElem)

src/plugins/plotting/TransportPlotting.cc

@@ -20,9 +20,7 @@
 namespace gz::gui::plugins
 {
 //////////////////////////////////////////
-TransportPlotting::~TransportPlotting()
-{
-}
+TransportPlotting::~TransportPlotting() = default;
 
 //////////////////////////////////////////
 void TransportPlotting::LoadConfig(const tinyxml2::XMLElement *)
@@ -32,7 +30,7 @@ void TransportPlotting::LoadConfig(const tinyxml2::XMLElement *)
 }
 
 //////////////////////////////////////////
-TransportPlotting::TransportPlotting() : Plugin(),
+TransportPlotting::TransportPlotting() :
     dataPtr(new PlottingInterface)
 {
 }

src/plugins/point_cloud/PointCloud.cc

@@ -98,8 +98,7 @@ using namespace plugins;
 
 /////////////////////////////////////////////////
 PointCloud::PointCloud()
-  : gz::gui::Plugin(),
-    dataPtr(std::make_unique<PointCloudPrivate>())
+  : dataPtr(std::make_unique<PointCloudPrivate>())
 {
 }
 

src/plugins/publisher/Publisher.cc

@@ -51,14 +51,12 @@ class PublisherPrivate
 
 /////////////////////////////////////////////////
 Publisher::Publisher()
-  : Plugin(), dataPtr(new PublisherPrivate)
+  : dataPtr(new PublisherPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-Publisher::~Publisher()
-{
-}
+Publisher::~Publisher() = default;
 
 /////////////////////////////////////////////////
 void Publisher::LoadConfig(const tinyxml2::XMLElement *_pluginElem)

src/plugins/screenshot/Screenshot.cc

@@ -57,8 +57,7 @@ class ScreenshotPrivate
 
 /////////////////////////////////////////////////
 Screenshot::Screenshot()
-  : gui::Plugin(),
-  dataPtr(std::make_unique<ScreenshotPrivate>())
+  : dataPtr(std::make_unique<ScreenshotPrivate>())
 {
   std::string home;
   common::env(GZ_HOMEDIR, home);

src/plugins/shutdown_button/ShutdownButton.cc

@@ -25,9 +25,7 @@
 namespace gz::gui::plugins
 {
 /////////////////////////////////////////////////
-ShutdownButton::ShutdownButton() : Plugin()
-{
-}
+ShutdownButton::ShutdownButton() = default;
 
 /////////////////////////////////////////////////
 ShutdownButton::~ShutdownButton() = default;

src/plugins/tape_measure/TapeMeasure.cc

@@ -90,8 +90,7 @@ class TapeMeasurePrivate
 
 /////////////////////////////////////////////////
 TapeMeasure::TapeMeasure()
-  : gz::gui::Plugin(),
-  dataPtr(std::make_unique<TapeMeasurePrivate>())
+  : dataPtr(std::make_unique<TapeMeasurePrivate>())
 {
 }
 

src/plugins/teleop/Teleop.cc

@@ -102,7 +102,7 @@ class TeleopPrivate
 };
 
 /////////////////////////////////////////////////
-Teleop::Teleop(): Plugin(), dataPtr(std::make_unique<TeleopPrivate>())
+Teleop::Teleop(): dataPtr(std::make_unique<TeleopPrivate>())
 {
   // Initialize publisher using default topic.
   this->dataPtr->cmdVelPub = transport::Node::Publisher();

src/plugins/topic_echo/TopicEcho.cc

@@ -49,17 +49,15 @@ class TopicEchoPrivate
 
 /////////////////////////////////////////////////
 TopicEcho::TopicEcho()
-  : Plugin(), dataPtr(new TopicEchoPrivate)
+  : dataPtr(new TopicEchoPrivate)
 {
   // Connect model
   App()->Engine()->rootContext()->setContextProperty("TopicEchoMsgList",
       &this->dataPtr->msgList);
 }
 
 /////////////////////////////////////////////////
-TopicEcho::~TopicEcho()
-{
-}
+TopicEcho::~TopicEcho() = default;
 
 /////////////////////////////////////////////////
 void TopicEcho::LoadConfig(const tinyxml2::XMLElement * /*_pluginElem*/)

src/plugins/topic_viewer/TopicViewer.cc

@@ -139,7 +139,7 @@ class TopicViewerPrivate
   public: std::vector<google::protobuf::FieldDescriptor::Type> plotableTypes;
 };
 
-TopicViewer::TopicViewer() : Plugin(), dataPtr(new TopicViewerPrivate)
+TopicViewer::TopicViewer() : dataPtr(new TopicViewerPrivate)
 {
   using namespace google::protobuf;
   this->dataPtr->plotableTypes.push_back(FieldDescriptor::Type::TYPE_DOUBLE);
@@ -161,9 +161,7 @@ TopicViewer::TopicViewer() : Plugin(), dataPtr(new TopicViewerPrivate)
 }
 
 //////////////////////////////////////////////////
-TopicViewer::~TopicViewer()
-{
-}
+TopicViewer::~TopicViewer() = default;
 
 //////////////////////////////////////////////////
 void TopicViewer::LoadConfig(const tinyxml2::XMLElement *)

src/plugins/transport_scene_manager/TransportSceneManager.cc

@@ -176,7 +176,7 @@ class TransportSceneManagerPrivate
 
 /////////////////////////////////////////////////
 TransportSceneManager::TransportSceneManager()
-  : Plugin(), dataPtr(new TransportSceneManagerPrivate)
+  : dataPtr(new TransportSceneManagerPrivate)
 {
 }
 

src/plugins/world_control/WorldControl.cc

@@ -71,14 +71,12 @@ class WorldControlPrivate
 
 /////////////////////////////////////////////////
 WorldControl::WorldControl()
-  : Plugin(), dataPtr(new WorldControlPrivate)
+  : dataPtr(new WorldControlPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-WorldControl::~WorldControl()
-{
-}
+WorldControl::~WorldControl() = default;
 
 /////////////////////////////////////////////////
 void WorldControl::LoadConfig(const tinyxml2::XMLElement *_pluginElem)

src/plugins/world_stats/WorldStats.cc

@@ -65,14 +65,12 @@ class WorldStatsPrivate
 
 /////////////////////////////////////////////////
 WorldStats::WorldStats()
-  : Plugin(), dataPtr(new WorldStatsPrivate)
+  : dataPtr(new WorldStatsPrivate)
 {
 }
 
 /////////////////////////////////////////////////
-WorldStats::~WorldStats()
-{
-}
+WorldStats::~WorldStats() = default;
 
 /////////////////////////////////////////////////
 void WorldStats::LoadConfig(const tinyxml2::XMLElement *_pluginElem)