Tidy namespaces #582
Tidy namespaces #582
Conversation
mjcarroll
force-pushed
the
mjcarroll/tidy_namespace
branch
2 times, most recently
from
187bbf1 to
b6011a8
Compare
Codecov Report
@@ Coverage Diff @@
## gz-gui8 #582 +/- ##
===========================================
- Coverage 68.10% 68.09% -0.01%
===========================================
Files 38 39 +1
Lines 5367 5372 +5
===========================================
+ Hits 3655 3658 +3
- Misses 1712 1714 +2
|
mjcarroll
force-pushed
the
mjcarroll/tidy_namespace
branch
from
b6011a8 to
8b9677b
Compare
|
@osrf-jenkins retest this please |
| @@ -37,191 +37,188 @@ namespace tinyxml2 | |||
| class XMLElement; | |||
| } | |||
|
|
|||
| namespace gz | |||
| namespace gz::gui | |||
There was a problem hiding this comment.
Do we plan to update all the libs within the gazebo ecosystem? If not, I'm slightly against making these changes so that we can keep all the libs in similar style
There was a problem hiding this comment.
Aspirationally, I would like to. Realistically, it takes time. I think that the more condensed looks and feels better, so moving in that direction over time seems appealing.
There was a problem hiding this comment.
Is there a reason we aren't starting at gz-gui7 or earlier? Will this make forward ports more painful?
There was a problem hiding this comment.
I think we need at least C++17, so targeting gui7 would be reasonable.
There was a problem hiding this comment.
let's do that. Also, we should create an issue that tracks the changes for all the other libs with a 'help wanted' label. It could be easy tasks for outside contributors
There was a problem hiding this comment.
Just opening another PR seems easier: #590
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/tidy_namespace
branch
from
3e5c68e to
3290544
Compare
Housekeeping to clean up namespaces.
Remove
using namespace gzand use nested namespace declarations where possible.