Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket proto request handling (backport #281) #283

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Nov 12, 2024

🦟 Bug fix

Depends on gazebosim/gz-msgs#470

Fixes #246

Summary

Added workaround to fix websocket proto message request. Duplicate message types should be removed in gazebosim/gz-msgs#470. In addition, nested messages also leads to duplicate messages so worked around it by leaving it out of the response.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.


This is an automatic backport of pull request #281 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <[email protected]>
(cherry picked from commit c60538a)
@mergify mergify bot requested a review from nkoenig as a code owner November 12, 2024 17:20
@mergify mergify bot mentioned this pull request Nov 12, 2024
8 tasks
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Nov 12, 2024
@arilow
Copy link

arilow commented Nov 12, 2024

Thanks @azeey!!

@azeey azeey merged commit 60c7943 into gz-launch7 Nov 12, 2024
10 checks passed
@azeey azeey deleted the mergify/bp/gz-launch7/pr-281 branch November 12, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants