Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for testing in non standard architectures #546

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

j-rivero
Copy link
Contributor

🦟 Bug fix

Summary

Fixes for tests in non x32 arches:

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Aug 11, 2023
@j-rivero j-rivero changed the title jrivero/non arch fixes for test Fixes for testing in non standard architectures Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #546 (2187d38) into ign-math6 (469540c) will not change coverage.
The diff coverage is n/a.

❗ Current head 2187d38 differs from pull request most recent head c83702c. Consider uploading reports for the commit c83702c to get more accurate results

@@            Coverage Diff             @@
##           ign-math6     #546   +/-   ##
==========================================
  Coverage      99.38%   99.38%           
==========================================
  Files             75       75           
  Lines           7029     7029           
==========================================
  Hits            6986     6986           
  Misses            43       43           

@mjcarroll mjcarroll merged commit a0c9148 into ign-math6 Aug 22, 2023
8 checks passed
@mjcarroll mjcarroll deleted the jrivero/non_arch_fixes_for_test branch August 22, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants