Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 24.04 CI, remove distutils dependency #587

Merged
merged 6 commits into from
Apr 18, 2024
Merged

Enable 24.04 CI, remove distutils dependency #587

merged 6 commits into from
Apr 18, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Attempting to enable CI on 24.04

Summary

The python3-distutils package is not available on 24.04, but we only use it in a codepath for old versions of cmake. Since we are already requiring cmake 3.22.1 in gz-cmake4, we can require that version in gz-math8 as well and remove code for old versions of cmake.

This isn't quite working yet due to an error using pip with python 3.12 on Noble.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>
Also don't need to install python3-distutils anymore.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters marked this pull request as ready for review April 18, 2024 17:12
@scpeters scpeters merged commit 2f1e049 into main Apr 18, 2024
9 checks passed
@scpeters scpeters deleted the scpeters/noble branch April 18, 2024 18:14
scpeters added a commit to gazebo-release/gz-math8-release that referenced this pull request Apr 18, 2024
No longer needed as of gazebosim/gz-math#587.

Signed-off-by: Steve Peters <[email protected]>
scpeters added a commit to gazebo-release/gz-math8-release that referenced this pull request Apr 18, 2024
No longer needed as of gazebosim/gz-math#587.

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants