Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix potential unsafe initialization in the Graph class (#606)" #609

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 17, 2024

🦟 Bug fix

This reverts commit 17585a9.

Summary

It appears that #606 and gazebosim/sdformat#1458 caused test failures in gz-sim (see osrf/buildfarm-tools#67 (comment)). I opened a test PR in gz-sim (gazebosim/gz-sim#2482) that builds against gz-math8 and sdformat15 with those changes reverted, and the tests were fixed:

Build Status https://build.osrfoundation.org/job/gz_sim-ci-pr_any-homebrew-amd64/637/

I don't know why this broke tests, but I propose reverting these changes for now until we can figure it out.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Rebase-and-Merge.

@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Jul 17, 2024
@scpeters
Copy link
Member Author

Cc @caguero

@scpeters
Copy link
Member Author

gazebosim/sdformat#1459 needs to be merged before this

@scpeters scpeters merged commit 2b8a2bb into main Jul 17, 2024
9 of 10 checks passed
@scpeters scpeters deleted the scpeters/revert_606 branch July 17, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants