Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when visualizing Lidars with points #1008

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Fix crash when visualizing Lidars with points #1008

merged 1 commit into from
Jun 3, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented May 31, 2024 •
edited by iche033
Loading

🦟 Bug fix

Fixes: #970

Summary

The change is already in gz-rendering7.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from iche033 as a code owner May 31, 2024 22:45
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label May 31, 2024
iche033
iche033 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed that visualizing lidar points no longer crashes

@iche033 iche033 merged commit 213765b into gazebosim:ign-rendering6 Jun 3, 2024
8 of 10 checks passed
@iche033 iche033 mentioned this pull request Jun 3, 2024
Closed
19 tasks
@azeey azeey deleted the fix_lidar_viz_points branch June 3, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @iche033