Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix using lightmap and emissive map together (#1047)" #1067

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 17, 2024

This reverts commit 6ec0c52.

🦟 Bug fix

Summary

Reverts #1047 because it changed the appearance of visuals with lightmaps.

Marked as draft as we are waiting to see if we can find another workaround to make emissive maps work together with lightmaps.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 marked this pull request as draft September 17, 2024 21:50
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 17, 2024
@iche033 iche033 changed the title [DRAFT] Revert "Fix using lightmap and emissive map together (#1047)" Revert "Fix using lightmap and emissive map together (#1047)" Sep 18, 2024
@iche033 iche033 marked this pull request as ready for review September 18, 2024 21:16
@iche033 iche033 requested a review from azeey September 18, 2024 21:20
@iche033 iche033 merged commit c0e7c30 into gz-rendering9 Sep 18, 2024
10 of 12 checks passed
@iche033 iche033 deleted the revert_lightmap branch September 18, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants