Clean up internal resources on Destroy #886
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Motivated by gazebosim/gz-sim#2084.
Went through and clean up resources and pointers when the objects destroyed. This is is to make sure that we don't hold on to any pointers after the engine is destroyed.
More info:
We have ogre pointers as member variables in different rendering classes. The destructors are called when they go out of scope. If the engine is destroyed before the destructors are called, the destructor may be calling function from pointers that are no longer valid. So this PR tries to clear and reset all pointers when objects are destroyed (before the engine is unloaded).
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.