Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #2232 to Fortress #2498

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Backport #2232 to Fortress #2498

merged 3 commits into from
Aug 2, 2024

Commits on Aug 1, 2024

  1. Remove systems if their parent entity is removed (#2232) 

    n particular if a user despawns an entity, the associated plugin gets removed. This should prevent issues like #2165. TBH I'm not sure if this is the right way forward as a system should technically be able to access any entity in a traditional ECS.

The PR has now been reworked and greatly simplified. All we do is stop all worker threads if an entity is removed and then recreate remaining threads.

Signed-off-by: Arjo Chakravarty <[email protected]>
    @arjo129 @iche033
    arjo129 authored and iche033 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    55a0f55 View commit details
    Browse the repository at this point in the history

  2. Initialize threadsNeedCleanUp (#2503) 

    Signed-off-by: Shameek Ganguly <[email protected]>
    @shameekganguly @iche033
    shameekganguly authored and iche033 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    c1aab2e View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Fix shader param test 

    Signed-off-by: Ian Chen <[email protected]>
    @iche033
    iche033 committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    9115c8f View commit details
    Browse the repository at this point in the history