Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CLI11 vendoring by default #167

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jan 8, 2025

🦟 Bug fix

Part of #135

Summary

CLI11 is available upstream, so don't vendor by default.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters
Copy link
Member Author

scpeters commented Jan 8, 2025

we may need to update the package metadata to ensure the cli11 dependency is installed properly in each platform. I don't see it in the gz-utils3 homebrew formula for example

@scpeters
Copy link
Member Author

scpeters commented Jan 8, 2025

we may need to update the package metadata to ensure the cli11 dependency is installed properly in each platform. I don't see it in the gz-utils3 homebrew formula for example

it's missing from both noble and homebrew, though homebrew doesn't report cmake warnings so its build status looks fine

@scpeters
Copy link
Member Author

scpeters commented Jan 8, 2025

we may need to update the package metadata to ensure the cli11 dependency is installed properly in each platform. I don't see it in the gz-utils3 homebrew formula for example

it's missing from both noble and homebrew, though homebrew doesn't report cmake warnings so its build status looks fine

updated metadata for homebrew in osrf/homebrew-simulation#2928 and Ubuntu in 6e8fead

the windows metadata still needs to be updated

scpeters added a commit to gazebo-tooling/release-tools that referenced this pull request Jan 10, 2025
@scpeters
Copy link
Member Author

the windows metadata still needs to be updated

adding cli11 to list of vcpkg dependencies to install in gazebo-tooling/release-tools#1230

I'm not sure what to do for conda (cc @traversaro)

@traversaro
Copy link
Contributor

I'm not sure what to do for conda (cc @traversaro)

At the conda-forge level, cli11 was already added as a dependency (and that was the reason why I added this option). For the gazebo internal conda-based Windows CI, I am not sure where dependencies are stored, perhaps @j-rivero may know more.

@traversaro
Copy link
Contributor

For the gazebo internal conda-based Windows CI, I am not sure where dependencies are stored, perhaps @j-rivero may know more.

Perhaps we need to add cli11 in https://github.com/gazebo-tooling/release-tools/blob/master/conda/envs/legacy/pixi.toml and re-generated the pixi.lock ?

@j-rivero
Copy link
Contributor

I've hijacked gazebo-tooling/release-tools#1230 to include the conda update.

@scpeters
Copy link
Member Author

I've hijacked gazebo-tooling/release-tools#1230 to include the conda update.

thanks! I'll mark this ready for review once we've merged gazebo-tooling/release-tools#1230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants