Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch gzserver from xml #548

Merged
merged 28 commits into from
May 21, 2024
Merged

Launch gzserver from xml #548

merged 28 commits into from
May 21, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented May 13, 2024

🎉 New feature

Part of #552

Summary

This patch allows to run gzserver (as an executable or as a composable node) from an xml file.

How to test it?

Use the provided gzserver.launch to run gzserver as an executable:

ros2 launch ros_gz_sim gz_server.launch world_sdf_file:=empty.sdf

Confirm that you see gzserver loading and verify that no container has been created:

caguero@cold:~/ros_gz_ws$ ros2 component list

Now CTRL-C gzserver and try the composable version:

ros2 launch ros_gz_sim gzserver.launch world_sdf_file:=empty.sdf use_composition:=True

Confirm that you see gzserver loading and verify that a new container has been created:

caguero@cold:~/ros_gz_ws$ ros2 component list
/ros_gz_container
  1  /gzserver

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

caguero and others added 21 commits April 10, 2024 19:30
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
launch_gz/launch_gz/actions/__init__.py Outdated Show resolved Hide resolved
launch_gz/launch_gz/actions/gzserver.py Outdated Show resolved Hide resolved
launch_gz/launch_gz/actions/gzserver.py Outdated Show resolved Hide resolved
launch_gz/setup.py Outdated Show resolved Hide resolved
author='Carlos Agüero',
author_email='[email protected]',
maintainer='Aditya Pande, Brandon Ong',
maintainer_email='[email protected], [email protected]',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update emails too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in 53c024a.

caguero and others added 5 commits May 13, 2024 18:13
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Base automatically changed from spawn_model_and_bridge_launch to gz_sim_ros_node_composition May 15, 2024 15:56
@caguero caguero marked this pull request as ready for review May 15, 2024 16:12
@caguero
Copy link
Contributor Author

caguero commented May 15, 2024

@mjcarroll , is this the idea that you had in mind with gzserver.launch?

Copy link
Collaborator

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, exactly what I had in mind. One small comment on dependency in the setup.py

launch_gz/setup.py Show resolved Hide resolved
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero merged commit 1ba6ebf into gz_sim_ros_node_composition May 21, 2024
3 checks passed
@caguero caguero deleted the launch_gz branch May 21, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants