[Do Not merge] Attempting to see if adding a cache will speed up the sdf::Root construction
#1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
construction I'm just checking if adding a cache makes any sense. Signed-off-by: Arjo Chakravarty <[email protected]>
scpeters
reviewed
Sep 9, 2024
| @@ -279,7 +279,7 @@ ElementPtr Element::Clone(sdf::Errors &_errors) const | |||
| if (this->dataPtr->value) | |||
| { | |||
| clone->dataPtr->value = this->dataPtr->value->Clone(); | |||
| SDF_ASSERT(clone->dataPtr->value->SetParentElement(clone), | |||
| SDF_ASSERT(clone->dataPtr->value->SetParentElementNoReparse(clone), | |||
There was a problem hiding this comment.
with the context that Param::Reparse was added in #589 to support parsing pose values based on the parent element's @degrees attribute value, I think it may be fine to clone Param values without reparsing.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
I'm just checking if adding a cache makes any sense. I probably broke 10 other things along the way and made the entire library thread-unsafe.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸