Fix state verification in check_editorfield for essayautograde question type #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusted the final state verification to correctly identify 'gaveup' instead of 'gradedwrong' when no marks are assigned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #81 where the
check_editorfieldmethod was incorrectly verifying the final state of an essayautograde question asgradedwronginstead ofgaveup.Changes
check_editorfieldmethod to set the expected final state togaveup.Alternative Solutions
Another PR #83 also addresses the same issue with a different approach. Either of these PRs can be used to resolve the state verification problem.