Merge pull request #1611 from gchq/bugfix/webhook-fix

Bugfix/webhook fix
gchq · Nov 5, 2024 · 33a86b1 · 33a86b1
2 parents 3eb13fa + 719bdc2
commit 33a86b1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/backend/package-lock.json b/backend/package-lock.json
diff --git a/backend/package.json b/backend/package.json
@@ -43,7 +43,7 @@
     "content-disposition": "^0.5.4",
     "dedent-js": "^1.0.1",
     "dev-null": "^0.1.1",
-    "express": "^5.0.1",
+    "express": "5.0.1",
     "express-session": "^1.18.0",
     "fflate": "^0.8.2",
     "grant": "^5.4.22",

diff --git a/backend/src/services/webhook.ts b/backend/src/services/webhook.ts
@@ -97,10 +97,15 @@ export async function sendWebhooks(
         agent: getHttpsAgent({
           rejectUnauthorized: webhook.insecureSSL,
         }),
-        headers,
+        headers: { 'Conent-Type': 'application/json', ...headers },
       })
       if (!response.ok) {
-        log.error({ eventKind, response }, 'Non 200 response received when sending Webhook.')
+        log.error(
+          { eventKind, response: { status: response.status, body: await response.text() } },
+          'Non 200 response received when sending Webhook.',
+        )
+      } else {
+        log.debug('Successfully sent webhook', { webhook, event: eventKind })
       }
     } catch (err) {
       log.error({ eventKind, err }, 'Unable to send Webhook.')