added optional advanced section on entry creation for adding users to… #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ARADDCC002
commented
Jun 12, 2024
ARADDCC002
commented
JR40159
requested changes
Jun 12, 2024
backend/src/services/model.ts
Outdated
| ...modelParams.collaborators, | ||
| { | ||
| entity: toEntity('user', user.dn), | ||
| roles: ['owner'], |
There was a problem hiding this comment.
Won't we always want the user who is making this request to be owner?
backend/src/services/model.ts
Outdated
| export type CreateModelParams = Pick<ModelInterface, 'name' | 'teamId' | 'description' | 'visibility' | 'settings'> | ||
| export type CreateModelParams = Pick< | ||
| ModelInterface, | ||
| 'name' | 'teamId' | 'description' | 'visibility' | 'settings' | 'collaborators' |
There was a problem hiding this comment.
Could you also add 'kind' to this list while you're here? I think I accidentally removed it at some point...
JR40159
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.