Skip to content

Commit

Permalink
Merge pull request #493 from gchq/fix/softmax-lmc-on-mac
Browse files Browse the repository at this point in the history
tests: remove skip for SoftmaxLMC test_predictions
  • Loading branch information
tp832944 authored Feb 10, 2025
2 parents d188af5 + 44c868b commit 1ece6f4
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions tests/units/classification/test_categorical.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,8 @@
Tests for the CategoricalClassification decorator.
"""

import platform
from unittest import expectedFailure

import pytest
import sklearn
import torch
from gpytorch.mlls import VariationalELBO
Expand Down Expand Up @@ -205,9 +203,6 @@ def setUp(self) -> None:
rng=self.rng,
)

# TODO(rg): Investigate why this fails on Mac
# https://github.com/gchq/Vanguard/issues/473
@pytest.mark.skipif(platform.system() == "Darwin", reason="Currently fails on Mac")
def test_predictions(self) -> None:
"""Predict on a test dataset, and check the predictions are reasonably accurate."""
# This test failed for eight different seeds in a row when fitting for only 10 iterations - this one really
Expand Down

0 comments on commit 1ece6f4

Please sign in to comment.